Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DragDropAction: Check that actor was actually clicked #1591

Merged
merged 5 commits into from Apr 4, 2023
Merged

DragDropAction: Check that actor was actually clicked #1591

merged 5 commits into from Apr 4, 2023

Conversation

lenemter
Copy link
Member

In master actor_clicked is triggered even if you only release mouse button on actor without actually clicking it.

@lenemter lenemter added the Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Mar 29, 2023
@lenemter lenemter requested a review from a team March 29, 2023 03:31
@lenemter lenemter requested a review from tintou March 29, 2023 07:25
@tintou tintou enabled auto-merge (squash) March 30, 2023 14:59
@lenemter lenemter mentioned this pull request Apr 4, 2023
Merged
@tintou tintou merged commit c0a77ad into master Apr 4, 2023
4 checks passed
@tintou tintou deleted the lenemter/check-for-clicked branch April 4, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmhewitt davidmhewitt davidmhewitt approved these changes

@tintou tintou Awaiting requested review from tintou

Assignees
No one assigned
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lenemter @tintou @davidmhewitt