Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate notification_group for notifications #1598

Merged
merged 7 commits into from Mar 30, 2023
Merged

Use separate notification_group for notifications #1598

merged 7 commits into from Mar 30, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Mar 30, 2023 •
edited

Fixes #705
Fixes #743

  • Uses separate notification_group for notifications
  • Rearranges groups in ui_group, so now PointerLocator and DwellClickTimer are shown everywhere

@lenemter lenemter marked this pull request as ready for review March 30, 2023 07:50
@lenemter lenemter requested review from tintou and removed request for tintou March 30, 2023 07:50
@lenemter lenemter marked this pull request as draft March 30, 2023 08:48
@lenemter lenemter changed the title Use feedback group for notifications Use separate notification_group for notifications Mar 30, 2023
@lenemter lenemter marked this pull request as ready for review March 30, 2023 09:10
@lenemter lenemter requested a review from a team March 30, 2023 09:11
@lenemter lenemter merged commit cf2b835 into master Mar 30, 2023
4 checks passed
@lenemter lenemter deleted the lenemter/use-feedback-group branch March 30, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lenemter @tintou