Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't manually map notifications while nudge animation is playing #1611

Merged
merged 4 commits into from Apr 4, 2023
Merged

Don't manually map notifications while nudge animation is playing #1611

merged 4 commits into from Apr 4, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Apr 2, 2023

Fixes this:
image

@lenemter lenemter requested a review from a team April 2, 2023 12:28
@lenemter lenemter mentioned this pull request Apr 4, 2023
Merged
@danirabbit
Copy link
Member

Hm, I was still able to reproduce that issue with this branch, but admittedly its very hard to reproduce 😅

danirabbit
danirabbit approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's much easier to produce in master than in this branch so 👍

@danirabbit danirabbit enabled auto-merge (squash) April 4, 2023 19:06
@danirabbit danirabbit merged commit 9cb7c0e into master Apr 4, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/fix-notifications-nudge branch April 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lenemter @danirabbit