WM: Init things that depend on GTK later #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review with whitespace changes hidden.
In Mutter 44, Gala crashes on startup due to trying to initialize GTK before Gala is fully initialized. This is the same issue we have trying to start Gala in Wayland mode, but we will have it in Mutter 44 in X11 mode too.
If we manually initialize GTK and all of our GTK dependant things in a "later", we can delay the initialization of GTK until a point where the compositor is ready to accept connections from GTK.
This fixes the crashing issue with Mutter 44 in X11 mode. It may unblock Wayland too, but I haven't tested yet.
I've been testing this for a bit and haven't noticed any regressions yet, but it'll need some testing, especially around the functionality that has been moved into this block.