Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WM: Drop Meta.ShadowFactory #1625

Merged
merged 3 commits into from Apr 6, 2023
Merged

WM: Drop Meta.ShadowFactory #1625

merged 3 commits into from Apr 6, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Apr 6, 2023 •
edited

Fixes #1534
Closes #511

Not sure what Meta.ShadowFactory does, but removing it solves the issue. Gnome Shell doesn't use it either.

@lenemter lenemter requested a review from a team April 6, 2023 10:54
@lenemter lenemter mentioned this pull request Apr 6, 2023
Closed
vjr
vjr approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@vjr vjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to resolve the issue for me (I use the unofficial IntelliJ IDEA IDE flatpak off flathub) and code is just removals, so LGTM!

@lenemter
Copy link
Member Author

lenemter commented Apr 6, 2023

Thank you @vjr

I'm going to merge this and see if it breaks anything.

@lenemter lenemter merged commit ca807c6 into master Apr 6, 2023
4 checks passed
@lenemter lenemter deleted the lenemter/drop-shadow-factory branch April 6, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjr vjr vjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange shadow artifacts in Java desktop applications Remove shadow keys
2 participants
@lenemter @vjr