Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double icon when crossing icon group #1670

Merged
merged 4 commits into from May 2, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented May 2, 2023

Fixes this:
image

@lenemter lenemter requested a review from a team May 2, 2023 08:42
@lenemter lenemter mentioned this pull request May 2, 2023
@danirabbit
Copy link
Member

@lenemter could you clarify what the issue is and steps to reproduce? I'm unsure what I should be testing for here

@lenemter
Copy link
Member Author

lenemter commented May 2, 2023

@danirabbit When you drop a window in an icon group two icons of the same window appear for a brief moment

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, confirmed!

@danirabbit danirabbit merged commit 85beeb8 into master May 2, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/icon-group-fix-double-icon branch May 2, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants