Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gala Systemd services #1692

Merged
merged 2 commits into from Jun 18, 2023
Merged

Update Gala Systemd services #1692

merged 2 commits into from Jun 18, 2023

Conversation

tintou
Copy link
Member

@tintou tintou commented Jun 13, 2023

Sync with what is currently done in GNOME Shell

data/meson.build Outdated Show resolved Hide resolved
@danirabbit danirabbit requested a review from a team June 13, 2023 21:58
tintou added a commit to elementary/session-settings that referenced this pull request Jun 13, 2023
Most of the x11 content is now shipped with Gala, reflect the target name changed in
elementary/gala#1692
data/gala.target Show resolved Hide resolved
data/gala@wayland.service.in Outdated Show resolved Hide resolved
@Marukesu
Copy link
Contributor

Marukesu commented Jun 13, 2023

one thing i noticed is that we are missing a gala-daemon.service, the auto-start file is already marked to be skipped. so it doesn't get started. would make sense provide it here or let it to another PR?

currently, i'm using a DBusActivated gala-daemon.service and added it to the gala.service wants.

@tintou
Copy link
Member Author

tintou commented Jun 13, 2023

Isn't it DBus activated?

@Marukesu
Copy link
Contributor

Isn't it DBus activated?

well, it doesn't provide a dbus .service file.

@tintou
Copy link
Member Author

tintou commented Jun 13, 2023

@Marukesu it can be added in another PR but I'm unsure that the "wants" is actually necessary as we are explicitly connecting to it?

Sync with what is currently done in GNOME Shell
Copy link
Contributor

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, i couldn't test the wayland session, it get killed after a key press (this happens when not managed by systemd too).

the only suspicious error in journalctl is Gtk.StyleContext warning that it cannot find a display.

RestartSec=0ms
# Kill any stubborn child processes after this long
TimeoutStopSec=5

# Lower down gnome-shell's OOM score to avoid being killed by OOM-killer too early
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed the rename here.

@danirabbit danirabbit enabled auto-merge (squash) June 18, 2023 16:10
@danirabbit danirabbit merged commit befba69 into master Jun 18, 2023
4 checks passed
@danirabbit danirabbit deleted the tintou/systemd branch June 18, 2023 16:11
tintou added a commit to elementary/session-settings that referenced this pull request Jun 19, 2023
Most of the x11 content is now shipped with Gala, reflect the target name changed in
elementary/gala#1692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants