Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PiP: Check workspace before hiding the window #1708

Merged
merged 5 commits into from Jul 6, 2023
Merged

PiP: Check workspace before hiding the window #1708

merged 5 commits into from Jul 6, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Jul 4, 2023

Fixes #1700

@lenemter lenemter requested a review from a team July 4, 2023 12:59
@zeebok
Copy link
Contributor

zeebok commented Jul 5, 2023

Code looks good. I will test this tonight!

zeebok
zeebok approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@lenemter lenemter merged commit 441b5bb into master Jul 6, 2023
4 checks passed
@lenemter lenemter deleted the pip-check-workspace branch July 6, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PiP doesn't become visible by changing workspaces
2 participants
@lenemter @zeebok