Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #1717

Merged
merged 4 commits into from Jul 19, 2023
Merged

Fix warnings #1717

merged 4 commits into from Jul 19, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Jul 7, 2023

Fixes warnings spam from WindowClone introduced in 14767bf

@lenemter lenemter requested a review from a team July 7, 2023 10:23
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get like massive glitches and issues with this branch 😬 Multitasking view is really messed up with icon placement and no close buttons and wingpanel indicators won't open

@lenemter
Copy link
Member Author

@danirabbit Can you try to test this again. I sometimes randomly encounter such issues while developing. Maybe that's the case because I don't have any glitches on my side.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, weird. After trying this again everything works as expected!

@danirabbit danirabbit merged commit eef351e into master Jul 19, 2023
4 checks passed
@danirabbit danirabbit deleted the fix-warnings branch July 19, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants