Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow to wallpaper clones while switching workspace #1726

Merged
merged 1 commit into from Jul 18, 2023

Conversation

lenemter
Copy link
Member

Addresses #1004

@lenemter lenemter requested a review from a team July 12, 2023 13:24
@zeebok
Copy link
Contributor

zeebok commented Jul 18, 2023

I went to test this in a VM and the code can't be grabbed from that branch? When I have the chance to get the VM an ssh key setup I will try to just clone and checkout the branch.

@vjr
Copy link
Member

vjr commented Jul 18, 2023

I went to test this in a VM and the code can't be grabbed from that branch? When I have the chance to get the VM an ssh key setup I will try to just clone and checkout the branch.

You can also just git clone the http(s) link to the repo so no ssh keys required? Then git checkout the this branch from there?

About your question for downloading ZIP for the PR/branch, I wonder if you just download the ZIP for the repo/main branch and will it have the .git folders so you can git checkout to switch branches that way too.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Nice job!

@danirabbit danirabbit merged commit e119dd5 into master Jul 18, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/wallpaper-clones-shadow branch July 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants