Don't use Gtk.init #1762
Merged
Don't use Gtk.init #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixes the issue for me, I'm not sure about unintended side effects and the other distros as you said though so I'll leave a review to someone else 🤷 |
|
I'm tempted to just merge this, it's easy enough to revert if we see something wrong |
tintou
approved these changes
Sep 29, 2023
|
This change causes an X11 session to crash on Fedora 38. After reverting the change, the session works. A Wayland session crashes both with and without the change. @tintou do you have any idea how to better identify the reason for the crash in a Wayland session? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it breaks Wayland session. Needs to be tested on other distros.