Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate the vapi using the .metadata files #642

Merged
merged 1 commit into from Nov 21, 2019

Conversation

tintou
Copy link
Member

@tintou tintou commented Nov 21, 2019

We are now sure that we have the right symbols available with the right version

@tintou
Copy link
Member Author

tintou commented Nov 21, 2019

@worldofpeace can you see if that fixes #637

@danirabbit danirabbit merged commit 309d594 into master Nov 21, 2019
@danirabbit danirabbit deleted the tintou/vapi-regeneration branch November 21, 2019 20:00
@worldofpeace
Copy link
Contributor

@worldofpeace can you see if that fixes #637

Sure, will check 👍

@worldofpeace
Copy link
Contributor

Ok, compilation fails on NixOS Gnome 3.34 with these regenerated vapi's

lots with error: too few arguments to function 'g_boxed_free'.

@tintou What do you think about having a never ubuntu target in CI for the mutter using projects?
Just think it would make things easier to test against multiple mutter versions.

@tintou
Copy link
Member Author

tintou commented Nov 22, 2019

@worldofpeace it looks like an issue with Vala, can you try with Vala master to see if it has been fixed and otherwise open a bug there? I think that I was using latest Vala to build it here

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 22, 2019

@worldofpeace it looks like an issue with Vala, can you try with Vala master to see if it has been fixed and otherwise open a bug there? I think that I was using latest Vala to build it here

I suspected similar, will try.

Edit: 0.46.5 works, will get that into NixOS today.

@worldofpeace
Copy link
Contributor

Thanks, works 👍

Screenshot from 2019-11-22 03-34-57

Tested overview mode also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants