Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove margin from dialog action areas #161

Closed
danirabbit opened this issue Mar 2, 2018 · 2 comments · Fixed by #374
Closed

Remove margin from dialog action areas #161

danirabbit opened this issue Mar 2, 2018 · 2 comments · Fixed by #374
Assignees
@danirabbit
Labels
Status: In Progress
Projects
Dialog Action Areas

Comments

@danirabbit
Copy link
Member

danirabbit commented Mar 2, 2018 •
edited
Loading

get_action_area is deprecated and we can set margin in CSS these days
@danirabbit danirabbit added this to To do in Dialog Action Areas via automation Mar 2, 2018
@ghost
Copy link

ghost commented Mar 5, 2018 •
edited by ghost
Loading

What's about set margin to Gtk.Button instead to get_action_area ? I use it in Gtk.Dialog without deprecated warnings.

@danirabbit
Copy link
Member Author

It would be better to just do it once in the system stylesheet anyways. It would ensure consistency instead of leaving it up to each dialog

@danirabbit danirabbit moved this from To do to In progress in Dialog Action Areas Sep 28, 2020
@danirabbit danirabbit mentioned this issue Oct 14, 2020
Merged
@danirabbit danirabbit self-assigned this Oct 14, 2020
Dialog Action Areas automation moved this from In progress to Done Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danirabbit danirabbit

Labels
Status: In Progress
Projects
No open projects
Dialog Action Areas
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MessageDialog: Rely on stylesheet for action area margin elementary/granite
1 participant
@danirabbit