Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageDialog: Rely on stylesheet for action area margin #374

Merged
merged 3 commits into from
Oct 14, 2020
Merged

MessageDialog: Rely on stylesheet for action area margin #374

merged 3 commits into from
Oct 14, 2020

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Mar 9, 2020 •
edited
Loading

Fixes #161
Fixes deprecated call to get_action_area

Needs changes in the system stylesheet to look right

@danirabbit danirabbit marked this pull request as ready for review September 28, 2020 18:12
@danirabbit danirabbit mentioned this pull request Sep 28, 2020
Merged
@danirabbit danirabbit changed the title Padding/Margin with CSS MessageDialog: Rely on stylesheet for action area margin Sep 28, 2020
@danirabbit danirabbit added this to In progress in Dialog Action Areas via automation Sep 28, 2020
cassidyjames
cassidyjames approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the thing and looks right with the linked stylesheet branch.

@cassidyjames cassidyjames merged commit 4b9bc8c into master Oct 14, 2020
Dialog Action Areas automation moved this from In progress to Done Oct 14, 2020
@cassidyjames cassidyjames deleted the messagedialog-greenfield branch October 14, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassidyjames cassidyjames cassidyjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Dialog Action Areas
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove margin from dialog action areas
2 participants
@danirabbit @cassidyjames