Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add granite styles as a gresource #639

Merged
merged 14 commits into from
Apr 3, 2023
Merged

Add granite styles as a gresource #639

merged 14 commits into from
Apr 3, 2023

Conversation

danirabbit
Copy link
Member

Start moving Granite-specific styles into the library

@danirabbit danirabbit requested a review from a team March 15, 2023 15:33
Marukesu
Marukesu reviewed Mar 17, 2023
View reviewed changes
lib/Init.vala Outdated Show resolved Hide resolved
@dominichayesferen dominichayesferen mentioned this pull request Mar 24, 2023
Closed
Marukesu
Marukesu approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but it's seems that there's some missing styles in the granite demo when using Adwaita as the theme.

lib/Init.vala Outdated Show resolved Hide resolved
lib/Init.vala Outdated Show resolved Hide resolved
@danirabbit
Copy link
Member Author

Yeah for sure, it's not fully complete, just better than it was haha

@danirabbit @Marukesu
Apply suggestions from code review
b172579 
Co-authored-by: Gustavo Marques <pushstarttocontinue@outlook.com>
@danirabbit danirabbit enabled auto-merge (squash) April 3, 2023 18:19
@danirabbit danirabbit merged commit 6f035b7 into main Apr 3, 2023
@danirabbit danirabbit deleted the styles-resource branch April 3, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marukesu Marukesu Marukesu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danirabbit @Marukesu