New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Greeter using only Gtk+ #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintou
added
Priority: Wishlist
Status: Design Conflict
Won't be addressed due to a conflict with the HIG or other design considerations
Status: In Progress
and removed
Status: Design Conflict
Won't be addressed due to a conflict with the HIG or other design considerations
labels
Nov 5, 2018
danirabbit
reviewed
Nov 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks as we go :)
tintou
force-pushed
the
tintou/gtk-greeter
branch
from
November 6, 2018 13:13
7024edb
to
64ef499
Compare
tintou
force-pushed
the
tintou/gtk-greeter
branch
from
November 8, 2018 07:14
eb33723
to
7f1a304
Compare
tintou
force-pushed
the
tintou/gtk-greeter
branch
from
November 12, 2018 17:55
7f1a304
to
5f85319
Compare
tintou
force-pushed
the
tintou/gtk-greeter
branch
from
November 12, 2018 21:39
030d673
to
b3fcff4
Compare
Great work on this!
|
danirabbit
approved these changes
Nov 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Fixes #7
Fixes #13
Fixes #14
Fixes #31
Fixes #55
Fixes #69
Fixes #76
Fixes #108
Fixes #117
Fixes #159
Fixes #164
Fixes #175
Todo:
In Progress:
Done: