Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Greeter using only Gtk+ #181

Merged
merged 22 commits into from Nov 16, 2018
Merged

New Greeter using only Gtk+ #181

merged 22 commits into from Nov 16, 2018

Conversation

tintou
Copy link
Member

@tintou tintou commented Nov 5, 2018

Fixes #2
Fixes #7
Fixes #13
Fixes #14
Fixes #31
Fixes #55
Fixes #69
Fixes #76
Fixes #108
Fixes #117
Fixes #159
Fixes #164
Fixes #175

Todo:

In Progress:

Done:

  • No HiDPI detection. The greeter is running in LoDPI
  • Brightness control in the power indicator is not working
  • No indication when a user is logged in. Previously we overlayed a check mark on the avatar of logged in users Add check mark on logged in users #188
  • Wallpapers aren't pulled in from each user. It's always showing the default UserCard: use wallpaper path fallback code from old greeter #189
  • There is no feedback when a user fails to authenticate. Currently we shake the dialog and then make the password entry insensitive for that mandatory timeout period after a failed password attempt.
  • Login as guest button does nothing
  • Manual login button does nothing
  • The fingerprint indicator should probably only show if the user has a fingerprint configured
  • Wallpapers with a portrait aspect ratio don't show
  • Entry should grab keyboard focus when appropriate (likely when typing occurs) Grab entry focus when typing #197 Greeter window sometimes doesn't grab focus [$60] #144

@tintou tintou added Priority: Wishlist Status: Design Conflict Won't be addressed due to a conflict with the HIG or other design considerations Status: In Progress and removed Status: Design Conflict Won't be addressed due to a conflict with the HIG or other design considerations labels Nov 5, 2018
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks as we go :)

src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/DateTimeWidget.vala Outdated Show resolved Hide resolved
src/DateTimeWidget.vala Outdated Show resolved Hide resolved
src/DateTimeWidget.vala Outdated Show resolved Hide resolved
src/MainWindow.vala Outdated Show resolved Hide resolved
@peteruithoven
Copy link
Collaborator

peteruithoven commented Nov 14, 2018

Great work on this!
Works perfectly on HiDPI.
I noticed two issues:

  • The password field doesn't seem to grab focus.
    Unlike Greeter window sometimes doesn't grab focus [$60] #144, this happens consistently now.
    I noticed in the code that grab_focus is only called after the animate_error.
  • There is something visually wrong with the buttons on the bottom. Compare:
    Buttons in Greeter:
    screenshot from 2018-11-14 09 59 30 2x
    Buttons in Granite demo
    screenshot from 2018-11-14 10 18 16
    Looks like the text color is off and of the shadow color is the same as the text color?

@tintou tintou changed the title WIP: New Greeter using only Gtk+ New Greeter using only Gtk+ Nov 16, 2018
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants