Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Greeter using only Gtk+ #181

Merged
merged 22 commits into from Nov 16, 2018

Conversation

@tintou
Copy link
Member

commented Nov 5, 2018

Fixes #2
Fixes #7
Fixes #13
Fixes #14
Fixes #31
Fixes #55
Fixes #69
Fixes #76
Fixes #108
Fixes #117
Fixes #159
Fixes #164
Fixes #175

Todo:

In Progress:

Done:

  • No HiDPI detection. The greeter is running in LoDPI
  • Brightness control in the power indicator is not working
  • No indication when a user is logged in. Previously we overlayed a check mark on the avatar of logged in users #188
  • Wallpapers aren't pulled in from each user. It's always showing the default #189
  • There is no feedback when a user fails to authenticate. Currently we shake the dialog and then make the password entry insensitive for that mandatory timeout period after a failed password attempt.
  • Login as guest button does nothing
  • Manual login button does nothing
  • The fingerprint indicator should probably only show if the user has a fingerprint configured
  • Wallpapers with a portrait aspect ratio don't show
  • Entry should grab keyboard focus when appropriate (likely when typing occurs) #197 #144
@danrabbit
Copy link
Member

left a comment

Just a few nitpicks as we go :)

src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/Cards/UserCard.vala Outdated Show resolved Hide resolved
src/DateTimeWidget.vala Outdated Show resolved Hide resolved
src/DateTimeWidget.vala Outdated Show resolved Hide resolved
src/DateTimeWidget.vala Outdated Show resolved Hide resolved
src/MainWindow.vala Outdated Show resolved Hide resolved

@tintou tintou force-pushed the tintou/gtk-greeter branch from 7024edb to 64ef499 Nov 6, 2018

@tintou tintou force-pushed the tintou/gtk-greeter branch from eb33723 to 7f1a304 Nov 8, 2018

@tintou tintou force-pushed the tintou/gtk-greeter branch from 7f1a304 to 5f85319 Nov 12, 2018

@danrabbit danrabbit added this to In progress in Juno +1 Redesign via automation Nov 12, 2018

@tintou tintou force-pushed the tintou/gtk-greeter branch from 030d673 to b3fcff4 Nov 12, 2018

@danrabbit danrabbit requested a review from cassidyjames Nov 13, 2018

@peteruithoven

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

Great work on this!
Works perfectly on HiDPI.
I noticed two issues:

  • The password field doesn't seem to grab focus.
    Unlike #144, this happens consistently now.
    I noticed in the code that grab_focus is only called after the animate_error.
  • There is something visually wrong with the buttons on the bottom. Compare:
    Buttons in Greeter:
    screenshot from 2018-11-14 09 59 30 2x
    Buttons in Granite demo
    screenshot from 2018-11-14 10 18 16
    Looks like the text color is off and of the shadow color is the same as the text color?
danrabbit added 4 commits Nov 14, 2018
danrabbit and others added 2 commits Nov 16, 2018

@tintou tintou changed the title WIP: New Greeter using only Gtk+ New Greeter using only Gtk+ Nov 16, 2018

@danrabbit
Copy link
Member

left a comment

🚀

@danrabbit danrabbit merged commit 45167e5 into master Nov 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Juno +1 Redesign automation moved this from In progress to Done Nov 16, 2018

@danrabbit danrabbit deleted the tintou/gtk-greeter branch Nov 16, 2018

@worldofpeace worldofpeace referenced this pull request Nov 18, 2018
6 of 6 tasks complete
@peteruithoven peteruithoven referenced this pull request Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.