Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delayed time update after resuming from sleep #472

Merged
merged 15 commits into from
Dec 14, 2020
Merged

Fix delayed time update after resuming from sleep #472

merged 15 commits into from
Dec 14, 2020

Conversation

vjr
Copy link
Member

@vjr vjr commented Sep 11, 2020

Fix #306
Fix #383

@vjr
Copy link
Member Author

vjr commented Sep 11, 2020

@tintou or @davidmhewitt would you please take a look to help me figure out why I'm unable to capture the PrepareForSleep signal coming from the org.freedesktop.login1.Manager dbus interface?

I have placed a couple of warning level logs with my initials VJR which are not being logged although I do get the log from update_time ()

Thanks!

@vjr vjr marked this pull request as ready for review September 11, 2020 16:27
@vjr
Copy link
Member Author

vjr commented Sep 11, 2020

Ready for review!

@vjr vjr mentioned this pull request Sep 21, 2020
Closed
@marbetschar marbetschar mentioned this pull request Sep 28, 2020
Closed
davidmhewitt
davidmhewitt requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a code suggestion that should make your async method a lot more readable. Could you test that it's functionally equivalent?

src/Widgets/DateTimeWidget.vala Outdated Show resolved Hide resolved
@vjr
Copy link
Member Author

vjr commented Dec 14, 2020

I've left a code suggestion that should make your async method a lot more readable. Could you test that it's functionally equivalent?

Thanks! I've updated the code and it works as expected.

davidmhewitt
davidmhewitt approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sorry it took so long to review, and thank you for your patience and quick responses to my code reviews.

@davidmhewitt davidmhewitt merged commit f3c61cf into elementary:master Dec 14, 2020
@vjr
Copy link
Member Author

vjr commented Dec 14, 2020

Nice work!

Sorry it took so long to review, and thank you for your patience and quick responses to my code reviews.

Not at all, I'm the one who should be thanking you for the repeated and patient code reviews, so thank you!

@vjr vjr deleted the fix-time-update-after-sleep branch December 14, 2020 10:13
@gniezen
Copy link

gniezen commented Dec 14, 2020

This is very exciting, I'm looking forward to see the correct time on my login screen. Thanks for your work on this!

@vjr vjr mentioned this pull request Apr 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmhewitt davidmhewitt davidmhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login screen clock showing wrong time Wrong time displayed after suspend
4 participants
@vjr @gniezen @davidmhewitt @fabiozaramella