Improve HiDPI visuals - take 2 - simplified #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Just a note that this is to address issue #7 |
|
Does this supersede #51? If so, can you close it? Andrei |
|
You mean does this supersede #50 ? Which it does, so I closed that one. Thanks! |
|
Added the blocked status because this branch now requires GSD to be patched to actually send the |
|
I imagine this is no longer relevant now that the Juno greeter runs under a basic WM. It also has conflicting files so I'll close this and it can be re-opened at a later date if it's still needed for something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that it's confirmed GSD fails to signal when its plugins (like xsettings) are activated, as noted in PR #50 in this comment, here's a much simplified patch to try and make greeter look good on hidpi displays!
I'm still concerned about the need to call
Gtk.main_iteration_do (true)and the 1 second sleep is needed to allow (with fingers crossed) the xsettings GSD plugin to take effect (and thus the scaling-factor to be available) before clutter init.Hopefully this is good enough to at least get into Loki daily/testing PPA - I am really enjoying the improved hidpi look and would love to see this in Loki public stable update for regular users!