Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double login authentication #628

Merged
merged 4 commits into from Nov 25, 2022
Merged

Fix double login authentication #628

merged 4 commits into from Nov 25, 2022

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Nov 22, 2022 •
edited

Related to #624

@meisenzahl meisenzahl requested a review from vjr November 22, 2022 12:57
@mariadb-vishalrao
Copy link

Thanks for this. I can test and merge it only maybe in a couple of days time FYI.

@vjr
Copy link
Member

vjr commented Nov 22, 2022

Oops, previous comment was supposed to be from me haha.

danirabbit
danirabbit previously requested changes Nov 22, 2022
View reviewed changes
data/io.elementary.greeter.policy.in Outdated Show resolved Hide resolved
meisenzahl and others added 2 commits November 22, 2022 21:51
@danirabbit danirabbit dismissed their stale review November 23, 2022 01:33

Changes merged

vjr
vjr approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@vjr vjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... LGTM! works well too. Will merge this into my branch and update my PR to clean it up a bit and mark it ready for review shortly.

@vjr vjr merged commit 1eceae3 into fix-double-login Nov 25, 2022
@vjr vjr deleted the fix-double-login-authentication branch November 25, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjr vjr vjr approved these changes

@danirabbit danirabbit danirabbit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@meisenzahl @mariadb-vishalrao @vjr @danirabbit