Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user's xkb options #658

Merged
merged 9 commits into from
Jun 26, 2023
Merged

Use user's xkb options #658

merged 9 commits into from
Jun 26, 2023

Conversation

lenemter
Copy link
Member

Xkb options are responsible for "switch layout" shortcut, Compose key and Caps Lock behavior.

Requires elementary/settings-daemon#67

Fixes #541

@lenemter lenemter requested a review from a team June 15, 2023 11:01
@Marukesu
Copy link
Contributor

i think we should use the InputSources property provided in the org.freedesktop.Accounts.User interface and remove the related keys in the pantehon and settings daemon interfaces (why we duplicate the keyboard layout info?).

@zeebok
Copy link
Contributor

zeebok commented Jun 26, 2023

Maybe I am misunderstanding this PR or testing in VM is causing odd behavior, but the keyboard shortcuts such as compose key and switch layout do not work. At least when set to Caps Lock, that key's behavior remains default.

@lenemter
Copy link
Member Author

@zeebok Make sure you installed settings-daemon from git. Also, there is some bug with git version, it no longer autostarts for me after installing, so launch it manually from terminal. Hope it will make it work for you

Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright was able to test it correctly and confirm it works. Testing did reveal that if you have the Composer Key as Caps Lock, the alt+caps lock switch layout shortcut no longer works, but that is a bug for.... some other repo.

There is a conflict with master to fix, and the other comment from Marukesu to address, but this does work and look good.

@lenemter
Copy link
Member Author

@Marukesu I think this is out of scope of this PR. Can you file a new issue about duplicating keyboard info? Also, where do you find about this InputSources in org.freedesktop.Accounts.User. I tried to google anything, but found nothing about this.

@lenemter lenemter merged commit 6288e7c into master Jun 26, 2023
4 checks passed
@lenemter lenemter deleted the lenemter/sync-xkb-options branch June 26, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Some shortcuts to switch keyboard layout does not work on lockscreen
3 participants