Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compositor: Mask corners #661

Merged
merged 7 commits into from
Jun 19, 2023
Merged

Compositor: Mask corners #661

merged 7 commits into from
Jun 19, 2023

Conversation

lenemter
Copy link
Member

Fixes #25

@lenemter lenemter requested a review from a team June 15, 2023 14:42
@lenemter lenemter changed the title Mask corners Compositor: Mask corners Jun 15, 2023
@tintou
Copy link
Member

tintou commented Jun 15, 2023

I'd prefer not have a dependency on Gala on Greeter side

@tintou
Copy link
Member

tintou commented Jun 15, 2023

Don't forget to add any file you create in /po/POTFILES even if they do not contain translation

@lenemter
Copy link
Member Author

@tintou Seems like lots of compositor files are absent in POTFILES, should I add them too?

@tintou
Copy link
Member

tintou commented Jun 15, 2023

Yes, please do

@lenemter
Copy link
Member Author

@tintou Done

danirabbit
danirabbit approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected!

@danirabbit danirabbit merged commit e8d9c75 into master Jun 19, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/mask-corners branch June 19, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 7.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mask corners
3 participants
@lenemter @tintou @danirabbit