Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of users' accent color #667

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Improve handling of users' accent color #667

merged 3 commits into from
Jun 29, 2023

Conversation

lenemter
Copy link
Member

  • Set user's accent color globally using org.gnome.desktop.interface gtk-theme
  • Style each user's check individually

@lenemter lenemter requested a review from a team June 26, 2023 11:44
@lenemter lenemter marked this pull request as draft June 26, 2023 11:50
@lenemter lenemter removed the request for review from a team June 26, 2023 11:50
@lenemter lenemter marked this pull request as ready for review June 26, 2023 13:04
@lenemter lenemter requested a review from a team June 26, 2023 13:06
danirabbit
danirabbit reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Very cool getting the right accent color for the panel too. Nice job. Just one comment

src/MainWindow.vala Show resolved Hide resolved
danirabbit
danirabbit approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@danirabbit danirabbit merged commit bd25dd4 into master Jun 29, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/use-user-accent-color branch June 29, 2023 22:01
@danirabbit danirabbit mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lenemter @danirabbit