Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for network access #125

Merged
merged 9 commits into from Feb 1, 2022
Merged

Check for network access #125

merged 9 commits into from Feb 1, 2022

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Oct 13, 2021

Fixes #127
Alternative approach to elementary/onboarding#140

Peek.2021-10-13.07-37.mp4

@elementary/ux feel free to improve texts and layout 馃槄

@meisenzahl meisenzahl requested a review from a team October 13, 2021 05:44
@meisenzahl meisenzahl added the Needs Design Waiting for input from the UX team label Oct 13, 2021
@danirabbit
Copy link
Member

danirabbit commented Oct 13, 2021

I feel like launching full switchboard here is probably not a great idea since there's a lot of other things users could navigate to that don't make sense in this context

Ubiquity used to include a list of wireless networks natively in the installer for this step. I imagine it would be quite a bit more streamlined to do the same.

I also wonder if we shouldn't automatically go to the next step once we're connected?

Making a note that this is a pre-req for #35
And it makes sense to put this before the user/hostname step because of #120

@danirabbit
Copy link
Member

Revamped this a little bit. Since we have the network indicator available, we can onboard users to its functionality instead of duplicating UI. Also be more specific about functionality that requires internet

Screenshot from 2022-02-01 11 15 53

@danirabbit danirabbit enabled auto-merge (squash) February 1, 2022 19:25
@danirabbit danirabbit merged commit 1663911 into master Feb 1, 2022
@danirabbit danirabbit deleted the check-for-network-access branch February 1, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Connect to the internet
2 participants