New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrypt Before Try/Install #333
Conversation
src/Views/TryInstallView.vala
Outdated
|
||
var decrypt_button = new Gtk.Button.with_label (_("Unlock Encrypted Drives…")); | ||
|
||
// TODO: Only show decrypt infobar when we detect encrypted drives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In pop-os#126, this will soon be possible through InstallOptions.get_default ().contains_luks ()
. Then for getting a list of devices to decrypt, I'll add a borrow_disks ()
method which you could use to check partitions with partition.is_encrypted ()
, and for attempting the decryption with disks.decrypt_partition ()
.
@mmstick I think I'm ready for logic here. I could see some copy being tweaked but I'm pretty happy with the UI itself. |
I'm going to check this out and see if it I can get it working. |
I'm having some early success. The dialog is decrypting partitions and updating possible installation options. It's able to find the OS on a partition within an encrypted device and get that partition's UUID:
Now I just need to add a new button for enabling refresh installations that retains user accounts & |
@cassidyjames Converting to draft as conflicts with master and no recent activity. |
WIP. The goal is to add an infobar on the Try/Install view with an unlock button if encrypted partitions are detected. Then to use a new decryption dialog (which should ideally replace the existing popover from the custom partitioning view) to unlock any encrypted partitions.
TODO: