Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrypt Before Try/Install #333

Closed
wants to merge 29 commits into from
Closed

Conversation

cassidyjames
Copy link
Contributor

@cassidyjames cassidyjames commented May 25, 2018

WIP. The goal is to add an infobar on the Try/Install view with an unlock button if encrypted partitions are detected. Then to use a new decryption dialog (which should ideally replace the existing popover from the custom partitioning view) to unlock any encrypted partitions.

image

img_20180525_125231

TODO:

  • Styling for the infobar in a dialog? This is a little weird, but it seems like the right pattern to use.
  • Finish the DecryptDialog
  • Fix that shutdown button…

@cassidyjames cassidyjames added the Status: In Progress Someone is working on it label May 25, 2018

var decrypt_button = new Gtk.Button.with_label (_("Unlock Encrypted Drives…"));

// TODO: Only show decrypt infobar when we detect encrypted drives
Copy link
Collaborator

@mmstick mmstick May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pop-os#126, this will soon be possible through InstallOptions.get_default ().contains_luks (). Then for getting a list of devices to decrypt, I'll add a borrow_disks () method which you could use to check partitions with partition.is_encrypted (), and for attempting the decryption with disks.decrypt_partition ().

@cassidyjames
Copy link
Contributor Author

@mmstick I think I'm ready for logic here. I could see some copy being tweaked but I'm pretty happy with the UI itself.

@mmstick
Copy link
Collaborator

mmstick commented Aug 30, 2018

I'm going to check this out and see if it I can get it working.

@mmstick
Copy link
Collaborator

mmstick commented Aug 30, 2018

I'm having some early success. The dialog is decrypting partitions and updating possible installation options. It's able to find the OS on a partition within an encrypted device and get that partition's UUID:

found Pop!_OS on c9d68076-b5d0-4d61-aa64-285c8f88d28a

Now I just need to add a new button for enabling refresh installations that retains user accounts & /home.

@jeremypw jeremypw marked this pull request as draft April 28, 2021 18:12
@jeremypw
Copy link
Collaborator

@cassidyjames Converting to draft as conflicts with master and no recent activity.

@mmstick mmstick closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants