Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Locate Casper Directory #344

Merged
merged 26 commits into from Oct 22, 2019
Merged

Automatically Locate Casper Directory #344

merged 26 commits into from Oct 22, 2019

Conversation

mmstick
Copy link
Collaborator

@mmstick mmstick commented Jun 18, 2018

It doesn't need to be hard coded.

@codygarver codygarver self-requested a review June 21, 2018 13:27
@codygarver codygarver removed their request for review February 5, 2019 17:03
@danirabbit danirabbit requested a review from tintou April 30, 2019 23:53
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to change to make it more memory efficient and future-proof.
Don't forget to remove the option from the meson_options.txt file

src/Views/ProgressView.vala Outdated Show resolved Hide resolved
src/Views/ProgressView.vala Outdated Show resolved Hide resolved
src/Views/ProgressView.vala Outdated Show resolved Hide resolved
src/Views/ProgressView.vala Outdated Show resolved Hide resolved
src/Views/ProgressView.vala Outdated Show resolved Hide resolved
src/Views/ProgressView.vala Outdated Show resolved Hide resolved
danirabbit and others added 2 commits May 24, 2019 13:36
Co-Authored-By: Corentin Noël <corentin@elementary.io>
@danirabbit danirabbit requested a review from tintou May 24, 2019 20:42
Copy link
Member

@tintou tintou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tintou tintou requested a review from codygarver August 14, 2019 13:41
@tintou
Copy link
Member

tintou commented Aug 14, 2019

@codygarver adding you as a reviewer as you better know if that's what you want

Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy that this will still work in the context of both the new and old ways of us building .iso images, so this should be fine to merge.

@danirabbit danirabbit merged commit 33345f3 into master Oct 22, 2019
@danirabbit danirabbit deleted the casper-dir branch October 22, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants