New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically Locate Casper Directory #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to change to make it more memory efficient and future-proof.
Don't forget to remove the option from the meson_options.txt file
Co-Authored-By: Corentin Noël <corentin@elementary.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@codygarver adding you as a reviewer as you better know if that's what you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy that this will still work in the context of both the new and old ways of us building .iso images, so this should be fine to merge.
It doesn't need to be hard coded.