Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about VMs #625

Merged
merged 15 commits into from Dec 9, 2021
Merged

Warn about VMs #625

merged 15 commits into from Dec 9, 2021

Conversation

meisenzahl
Copy link
Member

Closes #323

Shows a warning as first view if running in a virtualized environment.

Simple solution

Bildschirmfoto von 2021-12-07 19 20 16

Shutdown button

Bildschirmfoto von 2021-12-07 19 33 27

Maybe a bit too much with a suggested shutdown button.

src/MainWindow.vala Outdated Show resolved Hide resolved
@meisenzahl
Copy link
Member Author

@cassidyjames sorry I was not aware of #326.

Last commit changed the layout based on your PR:

Bildschirmfoto von 2021-12-07 19 50 43

@cassidyjames
Copy link
Contributor

@meisenzahl shouldn't this be a part of CheckView where we perform other checks before installing?

@meisenzahl
Copy link
Member Author

@cassidyjames please excuse the confusion with your PR. There is now a warning when it detects that Installer is running in a virtual machine. I took the logic almost 1:1 from your PR. In addition, I have managed to display several warnings one after the other.

Peek.2021-12-08.20-20.mp4

The checks are not executed for

  • Try Demo Mode
  • Custom Install

Let's try to fix this in a follow-up PR.

@cassidyjames cassidyjames requested a review from a team December 8, 2021 23:27
@danirabbit danirabbit added this to In progress in OS 6.1 via automation Dec 9, 2021
@danirabbit danirabbit moved this from In progress to Needs Review in OS 6.1 Dec 9, 2021
@danirabbit danirabbit mentioned this pull request Dec 9, 2021
1 task
@danirabbit danirabbit removed this from Needs Review in OS 6.1 Dec 9, 2021
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this works as intended and that checkview code looks really not fun to work, so thank you for working on this!

@danirabbit danirabbit merged commit 703a3ae into master Dec 9, 2021
@danirabbit danirabbit deleted the warn-about-vms branch December 9, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn about VMs
3 participants