Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for screen reader shortcut after a timeout #711

Merged
merged 8 commits into from
Jul 21, 2023

Conversation

danirabbit
Copy link
Member

Fixes #471

Read out a screen reader prompt after 10 seconds if the user hasn't navigated in this time

@danirabbit danirabbit changed the title Danirabbit/espeak orca prompt Prompt for screen reader shortcut after a timeout Jul 21, 2023
@danirabbit danirabbit requested a review from a team July 21, 2023 17:55
@danirabbit
Copy link
Member Author

danirabbit commented Jul 21, 2023

I'm guessing this doesn't need to be localized because you'd need to either be able to see or activate the screen reader before selecting a language

danirabbit added a commit that referenced this pull request Jul 21, 2023
Not sure if should be depends instead? Goes with #711
@danirabbit danirabbit mentioned this pull request Jul 21, 2023
src/MainWindow.vala Outdated Show resolved Hide resolved
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a feeling the timeout length may end up needing future tweaking. There is no search on this first page so those whom need to scroll a bunch to find their language and layout may end up surprised by the voice.

@danirabbit danirabbit merged commit 37fdf66 into master Jul 21, 2023
4 of 5 checks passed
@danirabbit danirabbit deleted the danirabbit/espeak-orca-prompt branch July 21, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Automatically prompt for screen reader after a timeout
2 participants