Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications using URIs instead of filenames for the app icon do not display correctly #119

Closed
2 of 3 tasks
bluesabre opened this issue May 10, 2021 · 0 comments · Fixed by #120
Closed
2 of 3 tasks

Comments

@bluesabre
Copy link
Sponsor Member

Prerequisites

  • I have searched open and closed issues for duplicates.

Describe the bug

When a notification is sent with the app icon as a URI, it is not correctly displayed. This was observed using Google Chrome, where the app icon was "file:///tmp/.com.google.Chrome.rZmI2b". Instead of showing the Chrome icon, a image-missing icon was displayed instead.

To Reproduce

Steps to reproduce the behavior:

  1. Using Google Chrome, navigate to https://www.bennish.net/web-notifications.html
  2. Click the Authorize button to request web notifications.
  3. Click the Show button to send a notification.
  4. The notification is displayed with the site's image, overlaid with an image-missing icon.

Expected behavior

The notification should be overlaid with the application icon instead of a missing image.

Screenshots or screen recordings

Logs

Platform Information

elementary OS 6. Fully updated.

  • I'm using the latest version from git that I've manually compiled
  • I'm using the latest released stable version

Additional context

bluesabre added a commit to bluesabre/notifications that referenced this issue May 10, 2021
cassidyjames pushed a commit that referenced this issue May 13, 2021
* Handle URIs used for application icons (#119)

* Add missing space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant