Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix #117: Show icons for daemons (#118)" #122

Merged
merged 5 commits into from Sep 6, 2021

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented May 15, 2021

This reverts commit a6d20d5.

Please revert this. We shouldn't be loading desktop files from the autostart folder. This folder is only for desktop files that should be launched with the session (and they don't even need to be fully formed desktop files). Hence why this isn't in the standard lookup path for DesktopAppInfo.

If something (a daemon or otherwise) wants to send notifications, it should install a desktop file to an XDG applications path (e.g. /usr/share/applications). If it should be hidden from the applications menu because it's a daemon, use the NoDisplay key.

Originally posted by @davidmhewitt in #118 (comment)

@jeremypw
Copy link
Contributor

Assigning to David Hewitt as it is pursuant to his request.

@marbetschar marbetschar mentioned this pull request Sep 6, 2021
2 tasks
Copy link
Member

@marbetschar marbetschar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meisenzahl thanks for reverting my this-was-not-so-good change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants