Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued work on actions support #125

Merged
merged 26 commits into from Jun 1, 2021
Merged

Conversation

bluesabre
Copy link
Sponsor Member

This PR updates notifications/actions with the following:

  • Pulls in the latest changes from master.
  • Sets the close revealer alignment (start, start) to make action buttons clickable, otherwise it overlays the entire bubble with an unclickable space.
  • Use the actions as specified by the notifications, instead of the DesktopAppInfo actions which may conflict or lead to unexpected opening of the calling application.
  • Enables action support for applications without a valid app_info.

danirabbit and others added 26 commits October 7, 2020 22:56
Currently translated at 100.0% (2 of 2 strings)

Translation: Desktop/Notifications (Extra)
Translate-URL: https://l10n.elementary.io/projects/desktop/notifications-extra/it/
Currently translated at 100.0% (2 of 2 strings)

Translation: Desktop/Notifications (Extra)
Translate-URL: https://l10n.elementary.io/projects/desktop/notifications-extra/nl/
Currently translated at 100.0% (2 of 2 strings)

Translation: Desktop/Notifications (Extra)
Translate-URL: https://l10n.elementary.io/projects/desktop/notifications-extra/sr/
Updated by "Update LINGUAS file" hook in Weblate.

Translation: Desktop/Notifications (Extra)
Translate-URL: https://l10n.elementary.io/projects/desktop/notifications-extra/
Updated by "Update LINGUAS file" hook in Weblate.

Translation: Desktop/Notifications (Extra)
Translate-URL: https://l10n.elementary.io/projects/desktop/notifications-extra/
* AbstractBubble: Don't accept focus

* Update src/AbstractBubble.vala

Co-authored-by: Cassidy James Blaede <cassidy@elementary.io>

Co-authored-by: Cassidy James Blaede <cassidy@elementary.io>
* Handle URIs used for application icons (elementary#119)

* Add missing space
@bluesabre bluesabre mentioned this pull request May 26, 2021
@bluesabre bluesabre requested a review from danirabbit May 29, 2021 23:43
@danirabbit
Copy link
Member

This all makes sense, gonna go ahead and merge it into the actions branch :)

@danirabbit danirabbit merged commit bb5fcde into elementary:actions Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants