Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style View #103

Merged
merged 12 commits into from
Jul 23, 2020
Merged

Add Style View #103

merged 12 commits into from
Jul 23, 2020

Conversation

danirabbit
Copy link
Member

Screenshot from 2020-06-28 12 02 25@2x

Screenshot from 2020-06-28 12 02 13@2x

This increases the height here quite a bit. Not sure how we might want to address that

@cassidyjames
Copy link
Contributor

@danrabbit I feel like either we just do the default/dark preference here, or we figure out better spacing. It feels pretty cramped. I'm not opposed to letting the window get taller, but yeah, we'll want to check the other views as well and see how they feel. Something to keep in mind is if we plan to add a setting link on these pages, i.e. #29, as that will add extra height, too.

Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. I think like you mentioned in standup, we probably want to use a smaller size of illustration here. It's cramming a lot into this space while stretching out the height, making most of the other views feel super barren.

  2. I think this should be the second page, before Location Services. If in the future we support some sort of time-based adjusting of the style, we can decide how to order them—but for now, I think you want it as soon as possible in the flow.

@danirabbit
Copy link
Member Author

It's now the second view and the illustrations are significantly smaller

Screenshot from 2020-06-30 17 06 33@2x

Screenshot from 2020-06-30 17 06 41@2x

src/Views/StyleView.vala Show resolved Hide resolved
src/Views/StyleView.vala Outdated Show resolved Hide resolved
src/Views/StyleView.vala Outdated Show resolved Hide resolved
src/Views/StyleView.vala Outdated Show resolved Hide resolved
src/MainWindow.vala Outdated Show resolved Hide resolved
@cassidyjames cassidyjames merged commit 246c9d2 into master Jul 23, 2020
@cassidyjames cassidyjames deleted the style-view branch July 23, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants