-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Style View #103
Add Style View #103
Conversation
@danrabbit I feel like either we just do the default/dark preference here, or we figure out better spacing. It feels pretty cramped. I'm not opposed to letting the window get taller, but yeah, we'll want to check the other views as well and see how they feel. Something to keep in mind is if we plan to add a setting link on these pages, i.e. #29, as that will add extra height, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
-
I think like you mentioned in standup, we probably want to use a smaller size of illustration here. It's cramming a lot into this space while stretching out the height, making most of the other views feel super barren.
-
I think this should be the second page, before Location Services. If in the future we support some sort of time-based adjusting of the style, we can decide how to order them—but for now, I think you want it as soon as possible in the flow.
Co-authored-by: Cassidy James Blaede <cassidy@elementary.io>
This increases the height here quite a bit. Not sure how we might want to address that