-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GuestView #205
Add GuestView #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Online account are deleted once logged out, right? So I think we shouldn't show them in guest sessions?
@lenemter Yeah I'm on the fence on that one. If you're logging in to the guest account to check your email I think maybe it still makes sense to point to where to set up online accounts? |
@danirabbit Well, maybe. But IMO it's easier to use web browser than adding an online account if you're using guest session. Anyway, I don't confront your decision to show online accounts here. |
Yeah that's a good point. I'll remove it and we can always add it back in later if people make noise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work 🎉
Fixes #204
Fixes elementary/triage#144