Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GuestView #205

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Add GuestView #205

merged 6 commits into from
Apr 6, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Apr 5, 2023

@danirabbit danirabbit requested a review from a team April 5, 2023 00:45
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Online account are deleted once logged out, right? So I think we shouldn't show them in guest sessions?

src/Views/GuestView.vala Outdated Show resolved Hide resolved
@danirabbit
Copy link
Member Author

@lenemter Yeah I'm on the fence on that one. If you're logging in to the guest account to check your email I think maybe it still makes sense to point to where to set up online accounts?

@lenemter
Copy link
Member

lenemter commented Apr 5, 2023

@danirabbit Well, maybe. But IMO it's easier to use web browser than adding an online account if you're using guest session. Anyway, I don't confront your decision to show online accounts here.

@danirabbit
Copy link
Member Author

Yeah that's a good point. I'll remove it and we can always add it back in later if people make noise

@danirabbit danirabbit requested a review from lenemter April 5, 2023 17:43
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work 🎉

@lenemter lenemter merged commit 65a7b34 into master Apr 6, 2023
4 checks passed
@lenemter lenemter deleted the guest-view branch April 6, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle guest account warning Guest session warning message not translated in sytem locale
2 participants