Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StyleView: use actual background when available #212

Merged
merged 1 commit into from
Jun 24, 2023
Merged

StyleView: use actual background when available #212

merged 1 commit into from
Jun 24, 2023

Conversation

danirabbit
Copy link
Member

Screenshot from 2023-06-24 09 47 05

@danirabbit danirabbit requested a review from a team June 24, 2023 16:49
jeremypw
jeremypw approved these changes Jun 24, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected. There may be some wallpapers that may not work well with the images but I guess all the official ones should.

@jeremypw
Copy link
Collaborator

In order to accomodate dark-version wallpapers in dark mode the background for the dark mode button should be different from the light mode one but that can be dealt with separately,

@danirabbit danirabbit merged commit a0ee117 into master Jun 24, 2023
4 checks passed
@danirabbit danirabbit deleted the styleview-usebg branch June 24, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danirabbit @jeremypw