Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RedeyeTool Class Gobject-style constructed #683

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Make RedeyeTool Class Gobject-style constructed #683

merged 4 commits into from
Dec 1, 2021

Conversation

treppenwitz03
Copy link
Contributor

Make redeyetool gobject-style constructed. Also replaced specified type with var when there is clear indication of the instance.

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more nitpicking comment, otherwise looking good.

src/editing_tools/RedEyeTool.vala Outdated Show resolved Hide resolved
@treppenwitz03
Copy link
Contributor Author

I'll try that. thanks

@treppenwitz03
Copy link
Contributor Author

Should be fine by now. Thanks again @ryonakano

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@ryonakano ryonakano merged commit 52869e6 into elementary:master Dec 1, 2021
@treppenwitz03 treppenwitz03 deleted the gobject_construct_redeyetool branch December 1, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants