Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: remove geoclue agent #100

Merged
merged 1 commit into from
May 9, 2023
Merged

Desktop: remove geoclue agent #100

merged 1 commit into from
May 9, 2023

Conversation

danirabbit
Copy link
Member

Goes hand in hand with elementary/switchboard-plug-security-privacy#148 and elementary/default-settings#279

The agent doesn't work with newer version of GeoClue, but the portal does work, so this is part of switching over

@danirabbit danirabbit requested a review from a team May 2, 2023 18:13
@meisenzahl meisenzahl merged commit dc5f8b1 into jammy May 9, 2023
@meisenzahl meisenzahl deleted the desktop-rm-geoclueagent branch May 9, 2023 18:21
@bobby285271
Copy link
Member

Sorry if I comment in wrong place, I am trying to follow this change in NixOS but got stuck. I am actually trying to do some testing with flatpak com.belmoussaoui.ashpd.demo, for some reasons with the change I can make location requests but no longer can get a LocationUpdated response, this is not the case when I have either pantheon-agent-geoclue2 or geoclue-demo-agent installed (natively). Since ubuntu's geoclue-2.0 package provides geoclue-demo-agent, does that mean starting from now we need to enable it in NixOS also? 🤔

We have geoclue 2.7.0 and elementary/default-settings#279, elementary/switchboard-plug-security-privacy#148 are backported when testing.

@danirabbit
Copy link
Member Author

Can you open a new issue report on elementary/portals?

From my understanding, geoclue doesn't use agents at all anymore and now only supports the location portal

@danirabbit
Copy link
Member Author

@bobby285271 so I just tested on a fresh daily ISO here with no pantheon-agent-geoclue2 and I was able to get location for both the system timezone (which is using geoclue directly) and from Atlas (which is using the location portal)

@bobby285271
Copy link
Member

bobby285271 commented Jul 14, 2023

@danirabbit Hi, just to make sure, does pgrep -fa demos prints something like /usr/libexec/geoclue-2.0/demos/agent (which is the "geoclue-demo-agent" I mentioned above)? I wonder if the location still works if we kill these process

Edit: I downloaded a daily ISO, cannot test much but I guess the problem also exist there? 🤔

2023-07-14 09-46-03屏幕截图

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants