Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for firmware updates #45

Merged
merged 20 commits into from May 21, 2023
Merged

Check for firmware updates #45

merged 20 commits into from May 21, 2023

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Jan 12, 2022

Supersedes elementary/appcenter#1806

Screen_record_from_2022-01-12_21.33.00.mp4

@meisenzahl meisenzahl marked this pull request as ready for review January 12, 2022 20:36
@meisenzahl
Copy link
Member Author

If this is the way to go we have to add fwupd to debian packaging like in elementary/switchboard-plug-about#176.


check_seconds_between_refreshes ();

Timeout.add_seconds (SECONDS_BETWEEN_REFRESHES, check_seconds_between_refreshes);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using SystemD timers for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example project where we use systemd timer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You basically need an helper executable to be run at intervals.
The ArchLinux documentation is quite good on it: https://wiki.archlinux.org/title/Systemd/Timers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last commit I created a helper executable, a service and a timer. What is unclear to me is how I can trigger the action in the notification so that the firmware page can be opened in the settings, since the helper executable only runs for a short time. Is it possible to trigger an action from another application via a notification?

src/Application.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit requested a review from tintou April 6, 2022 18:10
@danirabbit danirabbit requested a review from a team November 8, 2022 21:40
@meisenzahl
Copy link
Member Author

Thanks to @Marukesu's idea everything works now as expected except for the notification icon:

@elementary/desktop-developers has anyone an idea why the icon is not used?

@meisenzahl meisenzahl requested a review from a team December 27, 2022 13:26
@meisenzahl meisenzahl mentioned this pull request Dec 27, 2022
@Marukesu
Copy link
Contributor

has anyone an idea why the icon is not used?

The notification server only search for desktop files in $datadir/applications folders, installing the autostart.desktop (as io.elementary.settings-daemon.desktop) there and linking to $configdir/autostart should work.

@meisenzahl
Copy link
Member Author

@Marukesu thank you very much for your feedback! It now works as expected.

src/Application.vala Show resolved Hide resolved
@meisenzahl meisenzahl merged commit 5751eeb into master May 21, 2023
5 checks passed
@meisenzahl meisenzahl deleted the check-for-firmware-updates branch May 21, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants