New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for firmware updates #45
Conversation
If this is the way to go we have to add |
src/Backends/Firmware.vala
Outdated
|
||
check_seconds_between_refreshes (); | ||
|
||
Timeout.add_seconds (SECONDS_BETWEEN_REFRESHES, check_seconds_between_refreshes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using SystemD timers for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example project where we use systemd timer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You basically need an helper executable to be run at intervals.
The ArchLinux documentation is quite good on it: https://wiki.archlinux.org/title/Systemd/Timers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the last commit I created a helper executable, a service and a timer. What is unclear to me is how I can trigger the action in the notification so that the firmware page can be opened in the settings, since the helper executable only runs for a short time. Is it possible to trigger an action from another application via a notification?
Co-authored-by: Danielle Foré <daniel@elementary.io>
.../check-for-firmware-updates/io.elementary.settings-daemon.check-for-firmware-updates.service
Outdated
Show resolved
Hide resolved
Thanks to @Marukesu's idea everything works now as expected except for the notification icon: @elementary/desktop-developers has anyone an idea why the icon is not used? |
The notification server only search for desktop files in |
@Marukesu thank you very much for your feedback! It now works as expected. |
Supersedes elementary/appcenter#1806
Screen_record_from_2022-01-12_21.33.00.mp4