Improve contrast in text selections #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
changed the title
|
Should we effectively deprecate |
|
@cassidyjames yeah I think that makes sense |
|
@cassidyjames I think we should address that in a different PR because it would require reworking a lot of stuff right now. That would significantly change colors in things and I think some of the gradients would be not so nice |
cassidyjames
approved these changes
Jan 3, 2020
worldofpeace
added a commit
to worldofpeace/nixpkgs
that referenced
this pull request
Jan 21, 2020
* Improve contrast in text selections elementary/stylesheet#572 * Add border and background to selected image radios elementary/stylesheet#576
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 28, 2020
* Improve contrast in text selections elementary/stylesheet#572 * Add border and background to selected image radios elementary/stylesheet#576 (cherry picked from commit dc18433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrast here goes from 2.8:1 to 8.8:1 in the light style and from 2.8:1 to 5.1:1 in the dark style. So oddly the effect looks less jarring but is way more contrasty
BEFORE
AFTER