Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pretty Hostname #227

Merged
merged 6 commits into from Aug 12, 2021
Merged

Use Pretty Hostname #227

merged 6 commits into from Aug 12, 2021

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Aug 10, 2021 •
edited

danirabbit
danirabbit requested changes Aug 11, 2021
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine here with fallbacks so I imagine we could merge this even before finishing the other branch.

Left a couple comments that we should probably still include null checks just in case we fail to connect to the system interface for some reason

src/Views/HardwareView.vala Outdated Show resolved Hide resolved
src/Views/HardwareView.vala Show resolved Hide resolved
@danirabbit danirabbit added this to In progress in OS 6.1 via automation Aug 11, 2021
@meisenzahl meisenzahl marked this pull request as ready for review August 12, 2021 10:28
danirabbit
danirabbit approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@danirabbit danirabbit merged commit 46a9a68 into master Aug 12, 2021
@danirabbit danirabbit deleted the use-pretty-hostname branch August 12, 2021 19:23
OS 6.1 automation moved this from In progress to Done Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 6.1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Pretty Hostname
2 participants
@meisenzahl @danirabbit