Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults: rewrite, responsive #188

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Defaults: rewrite, responsive #188

merged 2 commits into from
Jun 13, 2023

Conversation

danirabbit
Copy link
Member

  • Rewrite this view in a much more DRY way
  • Use a flowbox so that it (theoretically) shrinks at small window sizes
  • Put labels above comboboxes to make room for extra long app names eg "GNU Image Manipulation Program"

Screenshot from 2023-06-12 20 16 53

@danirabbit danirabbit requested a review from a team June 13, 2023 03:20
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, on my end it looks like this. I don't think it's supposed to have 3 columns.

Screenshot from 2023-06-13 12 46 08

@danirabbit
Copy link
Member Author

Ah yeah it depends on the apps you have installed, I guess.

@lenemter we can force a limit of 2 columns. Do you think that would be better?

@lenemter
Copy link
Member

@danirabbit Yes, Yes, that would be better. There is only 8 items in the defaults section, so it won't take too much vertical space.

@danirabbit danirabbit requested a review from lenemter June 13, 2023 15:29
@danirabbit danirabbit merged commit 558fecd into master Jun 13, 2023
4 checks passed
@danirabbit danirabbit deleted the defaults-rewrite branch June 13, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants