Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup: clean up, clamp, backport from Gtk4 #191

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Conversation

danirabbit
Copy link
Member

  • Code style and cleanup
  • Backport changes from Gtk 4 branch where possible
  • Clamp the list so that switches aren't super far away on large displays

@danirabbit danirabbit requested a review from a team June 14, 2023 16:50
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my 16" FHD laptop display the description text is small and barely readable. Can you make it larger somehow?

@danirabbit
Copy link
Member Author

@lenemter I would suggest adjusting your text size settings since we use the small text class for description text pretty regularly 😅 For example this is already the case in the AppChooser and this branch just brings those two row styles into alignment. It's also used in the sidebar in the Permissions view etc

@lenemter
Copy link
Member

@danirabbit I didn't notice they have the same size, I'll try to increase text size, thanks. Then it looks fine (btw it's pretty clever to use Clamp here 👍)

lenemter
lenemter previously approved these changes Jun 15, 2023
@danirabbit danirabbit merged commit 7377e84 into master Jun 15, 2023
4 checks passed
@danirabbit danirabbit deleted the startup-cleanupgtk4 branch June 15, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants