Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behavior: add a11y settings #446

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Behavior: add a11y settings #446

merged 7 commits into from
Jun 28, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 21, 2023 •
edited

Fixes #191
Fixes #192
Fixes #193

Screenshot from 2023-06-26 08 40 52

@danirabbit danirabbit marked this pull request as ready for review June 23, 2023 15:38
@danirabbit danirabbit requested a review from a team June 23, 2023 15:39
lenemter
lenemter reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound settings link is broken for me.

(io.elementary.switchboard:3635): switchboard-WARNING **: 23:28:57.960: Application.vala:100: Specified link '/sound/output' does not exist, going back to the main panel

@danirabbit danirabbit requested a review from lenemter June 24, 2023 23:24
@danirabbit danirabbit mentioned this pull request Jun 28, 2023
Merged
lenemter
lenemter approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 🎉

@lenemter lenemter merged commit 20f046b into master Jun 28, 2023
4 checks passed
@lenemter lenemter deleted the behavior-a11y branch June 28, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A11y
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose modifier key settings Expose "fast typing" settings from a11y Expose typing delays from a11y
2 participants
@danirabbit @lenemter