Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts: Allow configuring keybinds for launching dock items #513

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

leolost2605
Copy link
Member

Goes with elementary/dock#245

They show up but didn't test because of #512

Also the phrasing might need some improvement :)

@leolost2605 leolost2605 requested a review from a team May 30, 2024 11:21
@zeebok
Copy link

zeebok commented Jun 11, 2024

Is this still a valid PR to review? The blog says the dock now has the keyboard shortcuts.

Edit: Oh this is to change the shortcuts to launch items 0-9? Makes sense.

zeebok
zeebok previously approved these changes Jun 11, 2024
Copy link

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the language is okay for an initial version. I certainly can't think of something better off of the top of my head.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like to see a smarter way to set all of these at once in the future, but yeah this is good as a first version :)

@danirabbit danirabbit enabled auto-merge (squash) June 11, 2024 17:31
@danirabbit danirabbit merged commit 2faf6e8 into main Jun 11, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the leolost/dock-launching branch June 11, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants