Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointing: Check for existence of pointer reveal setting #124

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Pointing: Check for existence of pointer reveal setting #124

merged 3 commits into from
Jan 10, 2020

Conversation

danirabbit
Copy link
Member

Fixes #122

@danirabbit
Copy link
Member Author

@decathorpe does this solve the issue for you? I'm not sure if the entire schema was removed or if I need to check for that specific key

@danirabbit danirabbit changed the title Pointing: Check for existence of gsd mouse settings Pointing: Check for existence of pointer reveal setting Jan 10, 2020
@danirabbit danirabbit added this to In progress in Distro-agnostic Pantheon via automation Jan 10, 2020
decathorpe
decathorpe approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@decathorpe decathorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Opening the plug no longer crashes switchboard, and the setting for revealing the pointer is not shown.

Distro-agnostic Pantheon automation moved this from In progress to Reviewer approved Jan 10, 2020
@danirabbit danirabbit merged commit c5317eb into master Jan 10, 2020
Distro-agnostic Pantheon automation moved this from Reviewer approved to Done Jan 10, 2020
@danirabbit danirabbit deleted the check-mouse-schema branch January 10, 2020 22:50
@decathorpe
Copy link
Contributor

Thanks for fixing this! I really appreciate it.

@worldofpeace
Copy link
Contributor

💞 on my side as well @danrabbit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decathorpe decathorpe decathorpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Distro-agnostic Pantheon
Status: Done
Distro-agnostic Pantheon
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plug crashes with gnome-settings-daemon 3.34 (removed GSettings key)
3 participants
@danirabbit @decathorpe @worldofpeace