Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WifiMenuItem: Add Settings Dialog #226

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

WifiMenuItem: Add Settings Dialog #226

wants to merge 10 commits into from

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Nov 21, 2019 •
edited

BEFORE

Screenshot from 2019-11-21 10 34 09@2x

AFTER

Screenshot from 2019-11-21 15 51 03@2x

@danirabbit danirabbit marked this pull request as ready for review November 21, 2019 23:54
jeremypw
jeremypw previously requested changes Jan 29, 2020
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a new user might benefit from a tooltip for the settings/info button. Also there are a couple of new long lines.

@jeremypw jeremypw dismissed their stale review June 4, 2021 18:52

Changes made

@jeremypw
Copy link
Collaborator

jeremypw commented Jun 4, 2021

@danrabbit I added a tooltip and fixed some minor issues. I meant to do this is a separate PR but accidentally pushed directly to this one - sorry. If you do not agree with anything please revert.

There is a new terminal warning
Gtk-WARNING **: 19:50:10.469: Negative content width -15 (allocation 1, extents 8x8) while allocating gadget (node button, owner GtkButton)
caused by this PR but I have so far been unable to track down the reason. Probably not a blocking issue but annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Conflicts with master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danirabbit @jeremypw @fabiozaramella