Caldav set calendar url of collection source #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
danirabbit
approved these changes
Sep 14, 2021
|
@marbetschar for details in the blog post, will this require users to remove and re-add their account to get this fix? |
|
@cassidyjames right now: Yes. Once #216 is merged as well, then a simple edit and re-save is enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues where adding/editing and removing task lists weren't possible in the Tasks app. All of this was due to missing information when adding the CalDAV account through Online Accounts (for details see: elementary/tasks#269 (comment))
The changes in this PR also enables us to drop a bunch of code which is no longer needed, because EDS is now capable to discover and add child sources (read "Task lists" or "Calendars") by itself.