Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: unbreak fedora #264

Merged
merged 1 commit into from
Jun 27, 2023
Merged

CI: unbreak fedora #264

merged 1 commit into from
Jun 27, 2023

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Jun 26, 2023

We build granite7 because that is not in fedora repositories, but since this plug hasn't ported to gtk4 yet there should be no reason to break CI due to this (though the case here is simple as missing sassc).

With the same reason there should be no need to install libadwaita right now.

(We will have to revisit this file anyway when we port things to gtk4 I assume, since the switchboard version is hardcoded to 6.0.2)

We build granite7 because that is not in fedora repositories, but since this plug
hasn't ported to gtk4 yet there should be no reason to break CI due to this.

With the same reason there should be no need to install libadwaita right now.
@bobby285271 bobby285271 marked this pull request as ready for review June 26, 2023 16:33
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ty!

@danirabbit danirabbit merged commit 9203ff0 into main Jun 27, 2023
5 checks passed
@danirabbit danirabbit deleted the wip/bobby285271/fix-ci branch June 27, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants