Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the library to ease the addition of providers. #56

Merged
merged 6 commits into from Oct 12, 2018

Conversation

tintou
Copy link
Member

@tintou tintou commented Sep 13, 2018

Removed GSignond and replaced libgsignon-glib by libsignon-glib
Fixes #55 Fixes #44 Fixes #39

Removed GSignond and replaced libgsignon-glib by libsignon-glib.
@tintou
Copy link
Member Author

tintou commented Sep 13, 2018

Will work once this is merged:
https://gitlab.com/accounts-sso/libsignon-glib/merge_requests/17

I'm going to continue to work on this so this branch is going to grow.

@vjr
Copy link
Member

vjr commented Oct 3, 2018

@tintou is it safe to remove an element from the list in the middle of a foreach?

                list.foreach ((nth) => {
                    if (nth.get_system_context () == path) {
                        list.remove (nth);
                    }
                });

@danirabbit danirabbit added this to To do in Pantheon Online Accounts Juno via automation Oct 9, 2018
@danirabbit danirabbit moved this from To do to Unreleased packages copied to Stable PPA in Pantheon Online Accounts Juno Oct 9, 2018
@danirabbit danirabbit moved this from Unreleased packages copied to Stable PPA to In Progress in Pantheon Online Accounts Juno Oct 9, 2018
Copy link

@codygarver codygarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now, just need somebody with accounts to prove the changes work. But I confirm it at least prompts for login.

@codygarver codygarver merged commit 855196f into master Oct 12, 2018
Pantheon Online Accounts Juno automation moved this from In Progress to Done Oct 12, 2018
@codygarver codygarver deleted the tintou/no-libray branch October 12, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants