Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dock: redesign #360

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Dock: redesign #360

merged 6 commits into from
Jun 28, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 28, 2023 •
edited
Loading

Closes #256
Closes #232

  • Update copyright header
  • Code style
  • Add description text where helpful
  • Use radios for dock hide mode
  • Everything in a scrolled window

BEFORE

Screenshot from 2023-06-28 11 00 08

AFTER

Screenshot from 2023-06-28 15 11 36

@danirabbit danirabbit requested a review from a team June 28, 2023 17:59
@lenemter
Copy link
Member

@danirabbit Can you resolve conflicts here please?

@danirabbit
Copy link
Member Author

@lenemter done!

lenemter
lenemter approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Good job.

@danirabbit danirabbit merged commit a247a02 into master Jun 28, 2023
4 checks passed
@danirabbit danirabbit deleted the dock-redesign branch June 28, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danirabbit @lenemter