Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerModeButton: cleanup #246

Merged
merged 10 commits into from
Feb 9, 2024
Merged

PowerModeButton: cleanup #246

merged 10 commits into from
Feb 9, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 8, 2024 •
edited

Screenshot from 2024-02-08 15 47 46

@danirabbit danirabbit requested a review from a team February 8, 2024 02:54
@lenemter
Copy link
Member

lenemter commented Feb 8, 2024

@danirabbit Can you resolve conflicts please?

@danirabbit
Copy link
Member Author

@lenemter done!

lenemter
lenemter approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but IMHO "Power Mode" label really needs some spacing.

(btw these icons are amazing, way better than previous ones)

@danirabbit
Copy link
Member Author

@lenemter yeah I'm gonna end up moving this around quite a bit more I think. this whole plug is kinda messy and has a lot of odd stuff going on 😅

@danirabbit danirabbit merged commit 3b1dbc4 into main Feb 9, 2024
3 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/powermodebutton-cleanup branch February 9, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenemter lenemter lenemter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danirabbit @lenemter