Add ConnectedDevices Box #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danirabbit
commented
Feb 10, 2024
•
danirabbit
commented
danirabbit
force-pushed
the
danirabbit/connected-devices
branch
from
f3d4c86
to
f0195d7
Compare
danirabbit
commented
Feb 17, 2024
Comment on lines
+191
to
+192
| if (model == "iPad") { | ||
| icon_name = "computer-tablet"; |
There was a problem hiding this comment.
This is obviously kind of a dirty little hack. I can remove this. It doesn't seem like there's a good way to figure out if the attached device is a tablet or laptop
danirabbit
commented
Mar 11, 2024
| } catch (IOError e) { | ||
| critical (e.message); | ||
| } | ||
| } | ||
|
|
||
| private void update_properties () { | ||
| coarse_battery_level = upower_device.battery_level != 1; | ||
|
|
||
| model = upower_device.model; // Can sometimes update eg when phone is trusted | ||
| percentage = upower_device.percentage; |
There was a problem hiding this comment.
We should probably check for coarse battery level here and if we can get a coarse battery level we should set percentage to reflect that level since percentage can be inaccurate in those cases
zeebok
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.